Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: drop pdf on wkhtmltopdf #9555

Merged
merged 1 commit into from
Dec 21, 2023
Merged

BREAKING CHANGE: drop pdf on wkhtmltopdf #9555

merged 1 commit into from
Dec 21, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 20, 2023

Removes PDF generation using wkhtmltopdf now that wkhtmltopdf has been archived and chromium-based PDF reaches feature parity.

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1613584) 71.37% compared to head (eff2e0d) 74.35%.
Report is 14 commits behind head on main.

Files Patch % Lines
src/Docfx.Common/Git/GitUtility.cs 66.66% 2 Missing and 2 partials ⚠️
src/Docfx.App/PdfBuilder.cs 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9555      +/-   ##
==========================================
+ Coverage   71.37%   74.35%   +2.97%     
==========================================
  Files         558      534      -24     
  Lines       24024    23099     -925     
  Branches     4173     4044     -129     
==========================================
+ Hits        17147    17175      +28     
+ Misses       5780     4825     -955     
- Partials     1097     1099       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih force-pushed the no-wkpdf branch 2 times, most recently from 87c55bb to ea0f125 Compare December 20, 2023 13:14
@yufeih yufeih marked this pull request as ready for review December 20, 2023 13:15
@yufeih yufeih merged commit 40cda09 into main Dec 21, 2023
8 checks passed
@yufeih yufeih deleted the no-wkpdf branch December 21, 2023 02:10
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant